liuxunorg commented on a change in pull request #3331: [Zeppelin-4049] Hadoop Submarine (Machine Learning) interpreter URL: https://github.com/apache/zeppelin/pull/3331#discussion_r265397993
########## File path: scripts/docker/submarine/submarine-interpreter-cpu-1.0.0/Dockerfile ########## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM zeppelin-tensorflow_1.10-hadoop_3.1.2-cpu:1.0.0 Review comment: 1. I have carefully considered the issue of the docker name. Otherwise it will be difficult to maintain in the future. 2. Because the name needs to include the name and version number of the main component in the image. 3. **Naming rules** + The name `_` indicates the separator, splitting different systems, for example: `tensorflow` and `hadoop` + The name`-` indicates the connector, the connection system and the version number, for example: `hadoop-3.1.2` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
