felixcheung commented on a change in pull request #3331: [Zeppelin-4049] Hadoop Submarine (Machine Learning) interpreter URL: https://github.com/apache/zeppelin/pull/3331#discussion_r265410906
########## File path: submarine/src/main/java/org/apache/zeppelin/submarine/commons/SubmarineConstants.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zeppelin.submarine.commons; + +/* + * NOTE: use lowercase + "_" for the option name + */ +public class SubmarineConstants { + // Docker container Environmental variable at `submarine-job-run-tf.jinja` + // and `/bin/interpreter.sh` + public static final String DOCKER_HADOOP_HDFS_HOME = "DOCKER_HADOOP_HDFS_HOME"; + public static final String DOCKER_JAVA_HOME = "DOCKER_JAVA_HOME"; + public static final String DOCKER_CONTAINER_TIME_ZONE = "DOCKER_CONTAINER_TIME_ZONE"; + public static final String INTERPRETER_LAUNCH_MODE = "INTERPRETER_LAUNCH_MODE"; + + // interpreter.sh Environmental variable + public static final String SUBMARINE_HADOOP_HOME = "SUBMARINE_HADOOP_HOME"; + public static final String HADOOP_YARN_SUBMARINE_JAR = "HADOOP_YARN_SUBMARINE_JAR"; + public static final String SUBMARINE_INTERPRETER_DOCKER_IMAGE + = "SUBMARINE_INTERPRETER_DOCKER_IMAGE"; + + public static final String ZEPPELIN_SUBMARINE_AUTH_TYPE = "zeppelin.submarine.auth.type"; + public static final String SUBMARINE_HADOOP_CONF_DIR = "SUBMARINE_HADOOP_CONF_DIR"; + public static final String SUBMARINE_HADOOP_KEYTAB = "SUBMARINE_HADOOP_KEYTAB"; + public static final String SUBMARINE_HADOOP_PRINCIPAL = "SUBMARINE_HADOOP_PRINCIPAL"; + public static final String SUBMARINE_HADOOP_KRB5_CONF = "submarine.hadoop.krb5.conf"; + + public static final String JOB_NAME = "JOB_NAME"; + public static final String CLEAN_CHECKPOINT = "CLEAN_CHECKPOINT"; + public static final String INPUT_PATH = "INPUT_PATH"; + public static final String CHECKPOINT_PATH = "CHECKPOINT_PATH"; + public static final String PS_LAUNCH_CMD = "PS_LAUNCH_CMD"; + public static final String WORKER_LAUNCH_CMD = "WORKER_LAUNCH_CMD"; + public static final String MACHINELEARING_DISTRIBUTED_ENABLE + = "machinelearing.distributed.enable"; Review comment: `machinelearing` -> `machinelearning` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
