liuxunorg commented on a change in pull request #3331: [Zeppelin-4049] Hadoop Submarine (Machine Learning) interpreter URL: https://github.com/apache/zeppelin/pull/3331#discussion_r266725506
########## File path: submarine/src/main/java/org/apache/zeppelin/submarine/IPySubmarineInterpreter.java ########## @@ -0,0 +1,44 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zeppelin.submarine; + +import org.apache.zeppelin.interpreter.InterpreterException; +import org.apache.zeppelin.python.IPythonInterpreter; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Properties; + +public class IPySubmarineInterpreter extends IPythonInterpreter { + + private static final Logger LOGGER = LoggerFactory.getLogger(IPySubmarineInterpreter.class); + + private PySubmarineInterpreter pySubmarineInterpreter; + + public IPySubmarineInterpreter(Properties properties) { + super(properties); + } + + @Override + public void open() throws InterpreterException { + PySubmarineInterpreter pySparkInterpreter = + getInterpreterInTheSameSessionByClassName(PySubmarineInterpreter.class, false); + + pySubmarineInterpreter Review comment: Currently we are using the `pySubmarineInterpreter` Later, when we supported the `IpySubmarineInterpreter`, I will add it again. I refer to the code of the `Zeppelin Python Interpreter`, I am not familiar with `ipython` at present, the current code, It can be used normally, Therefore, in order to stabilize the system, still retain this part of the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
