felixcheung commented on a change in pull request #3342: [ZEPPELIN-4031] Fixed 
Unable to detect that the interpreter process was killed manually
URL: https://github.com/apache/zeppelin/pull/3342#discussion_r268960035
 
 

 ##########
 File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ManagedInterpreterGroup.java
 ##########
 @@ -58,10 +58,19 @@ public InterpreterSetting getInterpreterSetting() {
   public synchronized RemoteInterpreterProcess 
getOrCreateInterpreterProcess(String userName,
                                                                              
Properties properties)
       throws IOException {
+    if (remoteIntpProcessIsShutdown()) {
+      LOGGER.info("Check whether the InterpreterProcess has been shutdown.");
+      // clean invalid session and dirty data of interpreterSetting
+      close();
 
 Review comment:
   same q about whether to close iff process is not running

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to