zjffdu commented on a change in pull request #3364: [ZEPPELIN-4155] Unable get
available HostAddress in multi-NIC environment
URL: https://github.com/apache/zeppelin/pull/3364#discussion_r284523852
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterUtils.java
##########
@@ -93,22 +97,53 @@ public static TServerSocket createTServerSocket(String
portRange)
throw new IOException("No available port in the portRange: " + portRange);
}
+ // 1) Multiple NetworkCard will be configured on some servers
+ // 2) In the docker container environment, A container will also generate
multiple virtual NetworkCard
Review comment:
Could you add java doc to explain the logic ?
To me, it seems to involves 2 steps:
1. find all available networkcards
2. loop all the neetworkcards, and use the first non-loopback ip address.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
