felixcheung commented on a change in pull request #3372: [ZEPPELIN-3623] Create
interpreter process in the cluster mode
URL: https://github.com/apache/zeppelin/pull/3372#discussion_r287620968
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/cluster/ClusterManagerServer.java
##########
@@ -312,8 +315,24 @@ public boolean openRemoteInterpreterProcess(
}
@Override
- public boolean createClusterInterpreterProcess(ClusterIntpProcParameters
clusterIntpProcParameters) {
- // TODO: ZEPPELIN-3623
+ public boolean createClusterInterpreterProcess(ClusterIntpProcParameters
clusterIntpProcParams) {
+ String userName = clusterIntpProcParams.userName;
+ String noteId = clusterIntpProcParams.noteId;
+ String replName = clusterIntpProcParams.replName;
+ String defaultIntpGroup = clusterIntpProcParams.defaultInterpreterSetting;
+
+ try {
+ Interpreter interpreter = interpreterFactory.getInterpreter(userName,
noteId, replName, defaultIntpGroup);
+ String id = interpreter.getInterpreterGroup().getId();
+ LOGGER.info("InterpreterGroupId = " + id);
+ interpreter.setCreateInptProcessInCluster(false);
+
+ interpreter.open();
+ } catch (InterpreterNotFoundException e) {
+ e.printStackTrace();
+ } catch (InterpreterException e) {
+ e.printStackTrace();
Review comment:
use LOGGER.error, don't use e.printStrackTrace()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
