zjffdu commented on a change in pull request #3371: [ZEPPELIN-4171]
Configuration paragraph is empty to execute
URL: https://github.com/apache/zeppelin/pull/3371#discussion_r287626188
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java
##########
@@ -601,10 +621,13 @@ public void setStatusToUserParagraph(Status status) {
return config;
}
+ // NOTE: function setConfig(...) will overwrite all configuration
+ // Merge configuration, you need to use function applyConfigSetting(...)
public void setConfig(Map<String, Object> config) {
Review comment:
Why not name `applyConfigSetting` as `mergeConfig` it is is used for merge
configuration ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
