liuxunorg commented on a change in pull request #3418: [ZEPPELIN-4241] 
Configure the interpreter docker container time zone
URL: https://github.com/apache/zeppelin/pull/3418#discussion_r309957052
 
 

 ##########
 File path: docs/quickstart/docker.md
 ##########
 @@ -192,8 +201,9 @@ Instead of build Zeppelin distribution package and docker 
image everytime during
 Zeppelin can run locally (such as inside your IDE in debug mode) and able to 
run Interpreter using 
[DockerInterpreterLauncher](https://github.com/apache/zeppelin/blob/master/zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java)
 by configuring following environment variables.
 
 
+1. zeppelin-site.xml
 
 Review comment:
   1. `ZEPPELIN_RUN_MODE ` already exist in 
https://github.com/apache/zeppelin/blob/master/conf/zeppelin-site.xml.template#L617
   2. `ZEPPELIN_DOCKER_CONTAINER_IMAGE ` already exist in 
https://github.com/apache/zeppelin/blob/master/conf/zeppelin-site.xml.template#L647
   
   i modify `Environment variable` to `Configuration variable`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to