prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329394436
########## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java ########## @@ -39,6 +40,7 @@ /** * Notebook repository sync with remote storage */ +@Immediate Review comment: I think this can be removed, it's usually required at only one place. If you are doing it there ( `bindAsContract(NotebookRepoSync.class).to(NotebookRepo.class).in(Immediate.class);` ) then this becomes optional. And hence changes in pom.xml can be reverted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
