bhavikpatel9977 commented on issue #3488: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo URL: https://github.com/apache/zeppelin/pull/3488#issuecomment-544512218 > Basically, I think it would be better to perform validation logic before starting the server. By doing it, you could avoid multithreading issues that you mentioned in my PR. But, what I worried about it, Shiro configuration is also pluggable in current code, thus you'd better consider the case that `shiro.ini` doesn't exist. WDYT? Yes, that is what I am doing validating the configuration before starting the server. As you said Shiro configuration is also pluggable in current code so it should get initialized after Shiro Environment gets initialized? Also is there any specific reason for moving logic (initialization of classes) from the default constructor to the main method?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
