prabhjyotsingh commented on a change in pull request #3488: [ZEPPELIN-4356]
Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3488#discussion_r340945687
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
##########
@@ -298,6 +301,27 @@ public void contextDestroyed(ServletContextEvent
servletContextEvent) {}
}
}
+ private static void validateShiroIni() throws Exception {
+ if (conf.getShiroPath().length() > 0) {
+ Ini ini = new Ini();
+ ini.loadFromPath(conf.getShiroPath());
+
+ Ini.Section usersSection = ini.get("users");
+ String activeDirectoryRealm = ini.getSectionProperty("main",
"activeDirectoryRealm");
Review comment:
I see two problems in this approach
- This is just a name user can choose it to be anything, for example
`activeDirectoryRealm` user can choose to write this as just `adRealm`
- What happens if in the future community adds a new realm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
