alexott commented on a change in pull request #3711: [ZEPPELIN-4710]. Allow to 
inject application id into custom spark url
URL: https://github.com/apache/zeppelin/pull/3711#discussion_r404664180
 
 

 ##########
 File path: 
spark/spark-scala-parent/src/main/scala/org/apache/zeppelin/spark/BaseSparkScalaInterpreter.scala
 ##########
 @@ -237,6 +237,13 @@ abstract class BaseSparkScalaInterpreter(val conf: 
SparkConf,
       case None =>
     }
 
+    val webUiUrl = properties.getProperty("zeppelin.spark.uiWebUrl");
+    if (!StringUtils.isBlank(webUiUrl)) {
+      this.sparkUrl = webUiUrl.replace("{{applicationId}}", sc.applicationId);
+    } else {
+      useYarnProxyURLIfNeeded()
+    }
+
 
 Review comment:
   Ok, that was my concern - if we can say that `applicationId` is safely 
generated, and not provided by user, then I'm ok...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to