Leemoonsoo commented on a change in pull request #3761:
URL: https://github.com/apache/zeppelin/pull/3761#discussion_r420171730
##########
File path: k8s/interpreter/100-interpreter-spec.yaml
##########
@@ -54,6 +54,14 @@ spec:
- name: {{key}}
value: {{value}}
{% endfor %}
+ {% if zeppelin.k8s.interpreter.cores is defined and
zeppelin.k8s.interpreter.memory is defined %}
+ resources:
+ requests:
+ memory: "{{zeppelin.k8s.interpreter.memory}}"
+ cpu: "{{zeppelin.k8s.interpreter.cores}}"
+ limits:
+ cpu: "{{zeppelin.k8s.interpreter.cores}}"
Review comment:
nit - How about adding some short comments here about why
`limits.memory` is not configured? maybe a link to this pull request
description? So later, other people can see this as a intentional when read the
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
