zjffdu commented on a change in pull request #3933:
URL: https://github.com/apache/zeppelin/pull/3933#discussion_r502794926
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -1488,8 +1488,15 @@ private void runAllParagraphs(NotebookSocket conn,
new TypeToken<List<Map<String, Object>>>() {
}.getType());
- getNotebookService().runAllParagraphs(noteId, paragraphs,
getServiceContext(fromMessage),
- new WebSocketServiceCallback<Paragraph>(conn));
+ if (!getNotebookService().runAllParagraphs(noteId, paragraphs,
getServiceContext(fromMessage),
+ new WebSocketServiceCallback<Paragraph>(conn))) {
+ Note note = getNotebookService().getNote(noteId,
getServiceContext(fromMessage), new SimpleServiceCallback());
Review comment:
I mean to add comment in the code so that user can understand what this
piece of code is doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
