zjffdu commented on a change in pull request #4120:
URL: https://github.com/apache/zeppelin/pull/4120#discussion_r634877594
##########
File path:
flink/interpreter/src/main/java/org/apache/zeppelin/flink/JobManager.java
##########
@@ -254,11 +255,12 @@ public void run() {
if (completedObject.has("external_path")) {
String checkpointPath =
completedObject.getString("external_path");
LOGGER.debug("Latest checkpoint path: {}", checkpointPath);
- if (!StringUtils.isBlank(checkpointPath)) {
+ if (!StringUtils.isBlank(checkpointPath) &&
!checkpointPath.equals(latestCheckpointPath)) {
Review comment:
Actually here 2 not is more readable. The if condition is when
checkpoint is not null and it is not the same as latestCheckpointPath.
If I change it to 1 not, it is a little harder to understand what the if
condition means
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
