Reamer commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-882361700


   > @Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you 
please help to review it? Thanks.
   
   I think your problems with updating the Thrift version are due to the ugly 
use of the interpreter shade jar.
   
   
https://github.com/apache/zeppelin/blob/0ec89755d3155c254bdf33cb7e9603f10708af65/zeppelin-interpreter-parent/pom.xml#L35-L46
   
   I am trying to solve the problem in my 
[interpreter_shade](https://github.com/Reamer/zeppelin/tree/interpreter_shade) 
branch. . But the changes depend on an update of the shade-plugin 
(https://github.com/apache/maven-shade-plugin/pull/100 or 
https://github.com/apache/maven-shade-plugin/pull/105) because Intellji does 
not use the shading jars 
[IDEA-93855](https://youtrack.jetbrains.com/issue/IDEA-93855) correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to