zjffdu commented on a change in pull request #4195: URL: https://github.com/apache/zeppelin/pull/4195#discussion_r683932041
########## File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java ########## @@ -337,4 +344,27 @@ public Map extractTableConfigOptions() { } return fields; } + + public boolean isTimeIndicatorType(Object type) { + return FlinkTypeFactory.isTimeIndicatorType((TypeInformation<?>) type); + } + + @Override + public Object lookupExecutor(ClassLoader classLoader, Object environmentSettings, Object sEnv) { Review comment: Yes, if you take a look at the pom.xml under `flink-shims` module, there's no flink dependency, because we can not specify flink dependency here, it leave its child module to decide which flink version to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org