Reamer commented on a change in pull request #4260:
URL: https://github.com/apache/zeppelin/pull/4260#discussion_r733566247



##########
File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -495,22 +497,33 @@ public void onMessage(NotebookSocket conn, String msg) {
   @OnClose
   public void onClose(Session session, CloseReason closeReason) throws 
IOException {
     NotebookSocket notebookSocket = 
sessionIdNotebookSocketMap.get(session.getId());
-    if (null == notebookSocket) {
-      session.close();

Review comment:
       @jongyoul I think that session.close() is unnecessary, because the 
session is already closed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to