[GitHub] [zeppelin] zjffdu commented on a change in pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

[GitBox]

zjffdu commented on a change in pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#discussion_r733608397



##########
File path: 
zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java
##########
@@ -81,7 +82,7 @@ public void close() {
   @Override
   public List<NotebookRepoSettingsInfo> getSettings(AuthenticationInfo 
subject) {
     LOGGER.warn("getSettings is not implemented for HdfsNotebookRepo");
-    return null;
+    return Collections.emptyList();

Review comment:
       I mean "remove"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org