zjffdu commented on a change in pull request #4252:
URL: https://github.com/apache/zeppelin/pull/4252#discussion_r738927892
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java
##########
@@ -651,5 +667,63 @@ public void updateNotePath() {
}
}
+ /**
+ * Unloads notes when reasonable amount of notes are in loaded state.
+ * Leverage a simple LRU cache for determing evictable notes. Ensure to
+ * not evict notes during save operation (dirty).
Review comment:
Is it enough only not evict notes during save(write) operation ? The
eviction may also affect read operation I am afraid (such as broadcast note to
frontend). Here's one ticket which is caused by concurrent read/write
operation. https://issues.apache.org/jira/browse/ZEPPELIN-5574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
