Reamer commented on pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264#issuecomment-966886217


   I also found deadlocks in the application after JSR356 was adapted for 
Websocket.
   I think the synchronised is a relic from the [old 
code](https://github.com/apache/zeppelin/commit/575df6890ea0349314c8f23a5c19c758779ea9f7#diff-dec5ec785ce8a55940664b101105bccd19b2d8c3c335eef5432eb4f8edf063faL69).
   
   I checked the `WebSocketRemoteEndpoint` implementation and you should be 
right.
   
   This PR LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to