eubnara opened a new pull request #4269:
URL: https://github.com/apache/zeppelin/pull/4269


   ### What is this PR for?
   A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html
   `fileId`, `blockSize` should be declared as `long`, not `int`.
   
   
   ### What type of PR is it?
   
   Bug Fix
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
   * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]
   https://issues.apache.org/jira/browse/ZEPPELIN-5594
   
   ### How should this be tested?
   * Strongly recommended: add automated unit tests for any new or changed 
behavior
     - I modified some value in the `HDFSFileInterpreterTest.java` to simulate 
integer overflow.
   * Outline any manual steps to test the PR here.
     - In the `file` interpreter, if you try to access any file with high (> 
2147483647) `fileId` or `blockSize`, you will see the 
exception(`java.lang.NumberFormatException`).
   
   
   
   ### Screenshots (if appropriate)
   
   ```
   ERROR [2021-11-29 14:46:51,519] 
({FIFOScheduler-org.apache.zeppelin.file.FileInterpreter1871691756-Worker-1} 
HDFSFileInterpreter.java[listAll]:249) - listall: listDir /user/*******
   com.google.gson.JsonSyntaxException: java.lang.NumberFormatException: 
Expected an int but was 4947954640 at line 1 column 585 path 
$.FileStatuses.FileStatus[2].fileId 
   ```
   
   ### Questions:
   * Does the licenses files need update?
   * Is there breaking changes for older versions?
   * Does this needs documentation?
     - I don't think so.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to