zjffdu commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r842482006
##########
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java:
##########
@@ -63,144 +53,130 @@ public void init(ZeppelinConfiguration conf) throws
IOException {
String endpoint = conf.getOSSEndpoint();
bucketName = conf.getOSSBucketName();
rootFolder = conf.getNotebookDir();
- // rootFolder is part of OSS key which doesn't start with '/'
- if (rootFolder.startsWith("/")) {
- rootFolder = rootFolder.substring(1);
- }
+ NOTE_MAX_VERSION_NUM = conf.getOSSNoteMaxVersionNum();
+ // rootFolder is part of OSS key which doesn't start with '/' or './' or
'.//'
Review Comment:
It's better to move this comment to function `formatPath`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
