zjffdu commented on code in PR #4362:
URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852616747


##########
zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java:
##########
@@ -56,6 +56,8 @@ public static void main(String[] args) throws Exception {
               "%python\nimport time\ntime.sleep(5)\nprint('done')");
       zClient.submitParagraph(noteId, paragraphId2);
       zClient.waitUtilParagraphRunning(noteId, paragraphId2);
+      // It's also ok here to call zClient.cancelNote(noteId);

Review Comment:
   It looks like test for NotebookRestApi#stopNoteJobs is missing, it is better 
to add test for it. Also need to revisit whether we need to add test for other 
rest api methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to