ganlute commented on PR #4410:
URL: https://github.com/apache/zeppelin/pull/4410#issuecomment-1188512777

   > Yes, I just want to know the reason why you delete some - complex - tests. 
Could you please tell me the reason why you delete them instead of modifying 
them?
   
   In fact, the implementation of the Alluxio interpreter is `fs.run(args)` and 
it is contained in the module "alluxio-shell".
   
   Without considering importing dependencies conflict between "alluxio-shell" 
and the other dependencies, maybe we just need add one "hello world" case like 
`ls` in test cases. Since the "hello world" case passed, if other case does not 
work well, it may be a bug of Alluxio not Zeppelin. In fact, at this time, I 
only import alluxio-shell as dependencies so it similar to above case. However, 
it is inevitable that dependencies will be imported and conflict may happened. 
So, the better way is to add all the Alluxio Cli test cases in Alluxio 
interpreter test case so that we are able to catch the conflict at the first 
time. However, it is a big project and need lots of works. As a compromise, I 
choose the only basic and daily used command test  to keep in the test cases.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to