[GitHub] [zeppelin] zkytech commented on a diff in pull request #4443: [ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

[GitBox]

zkytech commented on code in PR #4443:
URL: https://github.com/apache/zeppelin/pull/4443#discussion_r945426808


##########
livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java:
##########
@@ -180,6 +215,9 @@ protected List<String> parseSQLJsonOutput(String output) {
     List<String> rows = new ArrayList<>();
 
     String[] rowsOutput = output.split("(?<!\\\\)\\n");
+    if(rowsOutput.length <= 1){

Review Comment:
   > Could you add a comment to explain what this case mean?
   
   message.getData() for DDL statement is only 1 line : "df: 
org.apache.spark.sql.DataFrame = []"
   
   if continue , `String[] header = rowsOutput[1].split("\t");` will throw out 
of index exception, this is a bug in previous version.
   
   comment has been added in the next commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org