Reamer commented on code in PR #4498:
URL: https://github.com/apache/zeppelin/pull/4498#discussion_r1007741613
##########
zeppelin-integration/pom.xml:
##########
@@ -94,21 +110,55 @@
</exclusions>
<scope>test</scope>
</dependency>
-
+
<dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <artifactId>spark-scala-2.11</artifactId>
Review Comment:
Depending on the spark-scala-2.11 or spark-scale-2.12 profile, one or the
other dependency should be added.
##########
.github/workflows/frontend.yml:
##########
@@ -49,7 +49,7 @@ jobs:
restore-keys: |
${{ runner.os }}-zeppelin-
- name: Install application
- run: ./mvnw -B install -DskipTests -DskipRat -pl ${INTERPRETERS}
-Phadoop2 -Pscala-2.11
+ run: ./mvnw clean install -pl zeppelin-web -B -Pintegration
-Pspark-scala-2.11 -Pspark-2.4 -Phadoop2 -DskipTests -DskipRat -am
Review Comment:
You should use the same profiles that are used for testing. If the profiles
are not sufficient for testing, they must be adjusted so that the profiles are
the same during installation and testing.
The order of the Maven parameters should be the same for better overview.
The parameter `-B` should be at the end. This simplifies the local testing very
much.
##########
zeppelin-integration/pom.xml:
##########
@@ -94,21 +110,55 @@
</exclusions>
<scope>test</scope>
</dependency>
-
+
<dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <artifactId>spark-scala-2.11</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
</dependency>
<dependency>
- <groupId>org.rauschig</groupId>
- <artifactId>jarchivelib</artifactId>
- <version>0.7.1</version>
- <exclusions>
- <exclusion>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-compress</artifactId>
- </exclusion>
- </exclusions>
+ <groupId>org.apache.zeppelin</groupId>
+ <artifactId>spark-shims</artifactId>
Review Comment:
Perhaps the `spark-interpreter` dependency is what is actually needed here.
##########
zeppelin-web/pom.xml:
##########
@@ -41,6 +41,51 @@
<plugin.frontend.npmDownloadRoot>https://registry.npmjs.org/npm/-/</plugin.frontend.npmDownloadRoot>
</properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.zeppelin</groupId>
+ <artifactId>spark-scala-2.11</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.zeppelin</groupId>
+ <artifactId>spark-shims</artifactId>
Review Comment:
Same as above.
##########
zeppelin-web/pom.xml:
##########
@@ -41,6 +41,51 @@
<plugin.frontend.npmDownloadRoot>https://registry.npmjs.org/npm/-/</plugin.frontend.npmDownloadRoot>
</properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.zeppelin</groupId>
+ <artifactId>spark-scala-2.11</artifactId>
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
