Reamer commented on code in PR #4321:
URL: https://github.com/apache/zeppelin/pull/4321#discussion_r1020028572
##########
hbase/pom.xml:
##########
@@ -75,11 +75,23 @@
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-client</artifactId>
<version>${hbase.hbase.version}</version>
+ <exclusions>
Review Comment:
This is not a test dependency, so the exclude should be unnecessary. Normal
dependencies do not contain test libraries.
##########
pom.xml:
##########
@@ -1929,6 +1943,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
+ <version>${plugin.surefire.version}</version>
Review Comment:
The version is already stored here, so this is unnecessary.
https://github.com/apache/zeppelin/blob/aa4731e69916ed20a3aad56a89544d7a08d57d24/pom.xml#L1605-L1609
##########
pom.xml:
##########
@@ -1898,6 +1911,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
+ <version>${plugin.surefire.version}</version>
Review Comment:
The version is already stored here, so this is unnecessary.
https://github.com/apache/zeppelin/blob/aa4731e69916ed20a3aad56a89544d7a08d57d24/pom.xml#L1605-L1609
##########
hbase/pom.xml:
##########
@@ -75,11 +75,23 @@
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-client</artifactId>
<version>${hbase.hbase.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-annotations</artifactId>
<version>${hbase.hbase.version}</version>
+ <exclusions>
Review Comment:
This is not a test dependency, so the exclude should be unnecessary. Normal
dependencies do not contain test libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
