Reamer commented on code in PR #4520:
URL: https://github.com/apache/zeppelin/pull/4520#discussion_r1039331979
##########
pom.xml:
##########
@@ -1585,6 +1585,14 @@
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
<version>${plugin.scala.alchim31.version}</version>
+ <configuration>
Review Comment:
Thank you for solving the CI problem.
I would do the configuration of this plugin in the sub-projects. In most
Scala subprojects there is already a custom compiler configuration and the
settings from the parent pom.xml should have no effect there. It can be
confusing if there is compiler configuration in two places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
