huage1994 commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1176305796
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:
##########
@@ -342,17 +341,14 @@ public Scheduler getScheduler() {
// running under the scheduler of this session will be aborted.
String executionMode = getProperty(".execution.mode", "paragraph");
if (executionMode.equals("paragraph")) {
- Scheduler s = new RemoteScheduler(
- RemoteInterpreter.class.getSimpleName() + "-" +
getInterpreterGroup().getId() + "-" + sessionId,
- SchedulerFactory.singleton().getExecutor(),
Review Comment:
> Since previously the jobs were queued in the remote interpreter due to
parallelism in the Zeppelin server, the cancellation of jobs did not work,
which is why the test failed.
Hi @Reamer , Could you please explain the reason in more detail about why
the cancellation of jobs did not work?
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:
##########
@@ -342,17 +341,14 @@ public Scheduler getScheduler() {
// running under the scheduler of this session will be aborted.
String executionMode = getProperty(".execution.mode", "paragraph");
if (executionMode.equals("paragraph")) {
- Scheduler s = new RemoteScheduler(
- RemoteInterpreter.class.getSimpleName() + "-" +
getInterpreterGroup().getId() + "-" + sessionId,
- SchedulerFactory.singleton().getExecutor(),
Review Comment:
> Since previously the jobs were queued in the remote interpreter due to
parallelism in the Zeppelin server, the cancellation of jobs did not work,
which is why the test failed.
Hi @Reamer , Could you please explain the reason in more detail about why
the cancellation of jobs did not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
