Reamer commented on code in PR #4581:
URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178681796
##########
zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java:
##########
@@ -123,7 +123,7 @@ void testGetTemplateBindings() {
assertEquals("12321:12321" ,
p.get("zeppelin.k8s.interpreter.rpc.portRange"));
assertEquals("zeppelin.server.service" ,
p.get("zeppelin.k8s.server.rpc.service"));
assertEquals(12320 , p.get("zeppelin.k8s.server.rpc.portRange"));
- assertEquals("null", p.get("zeppelin.k8s.interpreter.user"));
+ assertEquals("zeppelin", p.get("zeppelin.k8s.interpreter.user"));
Review Comment:
This value is not good. If no user is specified, the value should still be
"null". It would be better if the property is not set for an empty user at all
and the Jinja2 template does not render the user. Can you change the behaviour
like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
