huage1994 commented on code in PR #4590:
URL: https://github.com/apache/zeppelin/pull/4590#discussion_r1180017995
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteManagerTest.java:
##########
@@ -162,6 +162,14 @@ public void testLruCache() throws IOException {
noteManager.removeNote(noteNew2.getId(), AuthenticationInfo.ANONYMOUS);
assertFalse(noteManager.containsNote(noteNew2.getPath()));
assertEquals(cacheThreshold, noteManager.getCacheSize());
+
+ // add cache + 1 without read flag
+ Note noteNew3 = createNote("/prod/notenew3");
+ noteManager.addNote(noteNew3, AuthenticationInfo.ANONYMOUS);
+
+ // since all dirty notes in the cache are with a read flag, the cache
removes noteNew3, because it has no read flag
+ assertEquals(cacheThreshold, noteManager.getCacheSize());
+ System.out.println(noteManager.containsNote(noteNew3.getPath()));
Review Comment:
```suggestion
assertTrue(noteManager.containsNote(noteNew3.getPath()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
