Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1188549738
##########
zeppelin-interpreter/pom.xml:
##########
@@ -242,6 +249,29 @@
<dateFormat>yyyy-MM-dd HH:mm:ss</dateFormat>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.antlr</groupId>
+ <artifactId>antlr4-maven-plugin</artifactId>
+ <version>${antlr4.version}</version>
+ <configuration>
+ <arguments>
+ <argument>-package</argument>
+ <argument>org.apache.zeppelin.antrl4</argument>
+ <argument>-o</argument>
+
<argument>${basedir}/src/main/java/org/apache/zeppelin/antrl4</argument>
+ </arguments>
+ <visitor>true</visitor>
+ <sourceDirectory>${basedir}/src/main/antrl4</sourceDirectory>
Review Comment:
This is the default. You can therefore leave it out.
##########
zeppelin-interpreter/pom.xml:
##########
@@ -242,6 +249,29 @@
<dateFormat>yyyy-MM-dd HH:mm:ss</dateFormat>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.antlr</groupId>
+ <artifactId>antlr4-maven-plugin</artifactId>
+ <version>${antlr4.version}</version>
+ <configuration>
Review Comment:
Please do not write the code to `src/main`.
A package does not need to be specified either.
The default location `${project.build.directory}/generated-sources/antlr4`
is perfect.
I think the configuration block is unnecessary.
##########
zeppelin-interpreter/src/main/antrl4/Sql.g4:
##########
@@ -0,0 +1,1976 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review Comment:
Please note here where you get the content from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
