Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1196585537
##########
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##########
@@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext
context) throws IOException {
});
}
+ private void setResult(Paragraph p,int size,List<String> createTableList){
+ List<InterpreterResultMessage> resultMessageList= p.getReturn().message();
+ if (p.getReturn().code()== InterpreterResult.Code.SUCCESS){//success
+ if (resultMessageList.size()==size){
+ int successSize=0;
+ for (InterpreterResultMessage
interpreterResultMessage:resultMessageList){
+ if(interpreterResultMessage.equals("Query executed successfully.
Affected rows : 1\n\n")){
+ successSize++;
+ }
+ }
+ if (successSize==size){
+ String text="createTableSql\n";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ }
+ InterpreterResult interpreterResult=new
InterpreterResult(InterpreterResult.Code.SUCCESS,
InterpreterResult.Type.TABLE,text);
+ p.setResult(interpreterResult);
+ }
+ }
+ }
+ }
+
+ private void debugParagraph(NotebookSocket conn,
+ ServiceContext context,
+ Message fromMessage) throws IOException {
+ String paragraphId = (String) fromMessage.get("id");
+ String noteId = connectionManager.getAssociatedNoteId(conn);
+ String text = (String) fromMessage.get("paragraph");
+ //split
+ List<String> createTableList= SqlSplitVisitor.splitSql(text,paragraphId);
+ int size=0;
+ text="";
Review Comment:
Why do you overwrite text? It is better to use a new name here.
##########
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##########
@@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext
context) throws IOException {
});
}
+ private void setResult(Paragraph p,int size,List<String> createTableList){
+ List<InterpreterResultMessage> resultMessageList= p.getReturn().message();
+ if (p.getReturn().code()== InterpreterResult.Code.SUCCESS){//success
+ if (resultMessageList.size()==size){
+ int successSize=0;
+ for (InterpreterResultMessage
interpreterResultMessage:resultMessageList){
+ if(interpreterResultMessage.equals("Query executed successfully.
Affected rows : 1\n\n")){
+ successSize++;
+ }
+ }
+ if (successSize==size){
+ String text="createTableSql\n";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ }
+ InterpreterResult interpreterResult=new
InterpreterResult(InterpreterResult.Code.SUCCESS,
InterpreterResult.Type.TABLE,text);
+ p.setResult(interpreterResult);
+ }
+ }
+ }
+ }
+
+ private void debugParagraph(NotebookSocket conn,
+ ServiceContext context,
+ Message fromMessage) throws IOException {
+ String paragraphId = (String) fromMessage.get("id");
+ String noteId = connectionManager.getAssociatedNoteId(conn);
+ String text = (String) fromMessage.get("paragraph");
+ //split
+ List<String> createTableList= SqlSplitVisitor.splitSql(text,paragraphId);
+ int size=0;
+ text="";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ size++;
+ }
+ String title = (String) fromMessage.get("title");
+ Map<String, Object> params = (Map<String, Object>)
fromMessage.get("params");
+ Map<String, Object> config = (Map<String, Object>)
fromMessage.get("config");
+ int finalSize = size;
+ String finalText = text;
+ getNotebook().processNote(noteId,
+ note -> {
+ getNotebookService().runParagraph(note, paragraphId, title, finalText,
params, config, null,
+ false, false, context,
+ new WebSocketServiceCallback<Paragraph>(conn) {
+ @Override
+ public void onSuccess(Paragraph p, ServiceContext context)
+ throws IOException {
+ super.onSuccess(p, context);
+ //change result
+ setResult(p, finalSize,createTableList);
Review Comment:
Why is it necessary to change the result of the paragraph?
##########
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##########
@@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext
context) throws IOException {
});
}
+ private void setResult(Paragraph p,int size,List<String> createTableList){
+ List<InterpreterResultMessage> resultMessageList= p.getReturn().message();
+ if (p.getReturn().code()== InterpreterResult.Code.SUCCESS){//success
+ if (resultMessageList.size()==size){
+ int successSize=0;
+ for (InterpreterResultMessage
interpreterResultMessage:resultMessageList){
+ if(interpreterResultMessage.equals("Query executed successfully.
Affected rows : 1\n\n")){
+ successSize++;
+ }
+ }
+ if (successSize==size){
+ String text="createTableSql\n";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ }
+ InterpreterResult interpreterResult=new
InterpreterResult(InterpreterResult.Code.SUCCESS,
InterpreterResult.Type.TABLE,text);
+ p.setResult(interpreterResult);
+ }
+ }
+ }
+ }
+
+ private void debugParagraph(NotebookSocket conn,
+ ServiceContext context,
+ Message fromMessage) throws IOException {
+ String paragraphId = (String) fromMessage.get("id");
+ String noteId = connectionManager.getAssociatedNoteId(conn);
+ String text = (String) fromMessage.get("paragraph");
+ //split
+ List<String> createTableList= SqlSplitVisitor.splitSql(text,paragraphId);
+ int size=0;
+ text="";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
Review Comment:
Have you ever heard of the StringBuilder?
##########
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##########
@@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext
context) throws IOException {
});
}
+ private void setResult(Paragraph p,int size,List<String> createTableList){
+ List<InterpreterResultMessage> resultMessageList= p.getReturn().message();
+ if (p.getReturn().code()== InterpreterResult.Code.SUCCESS){//success
+ if (resultMessageList.size()==size){
+ int successSize=0;
+ for (InterpreterResultMessage
interpreterResultMessage:resultMessageList){
+ if(interpreterResultMessage.equals("Query executed successfully.
Affected rows : 1\n\n")){
+ successSize++;
+ }
+ }
+ if (successSize==size){
+ String text="createTableSql\n";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ }
+ InterpreterResult interpreterResult=new
InterpreterResult(InterpreterResult.Code.SUCCESS,
InterpreterResult.Type.TABLE,text);
+ p.setResult(interpreterResult);
+ }
+ }
+ }
+ }
+
+ private void debugParagraph(NotebookSocket conn,
+ ServiceContext context,
+ Message fromMessage) throws IOException {
+ String paragraphId = (String) fromMessage.get("id");
+ String noteId = connectionManager.getAssociatedNoteId(conn);
+ String text = (String) fromMessage.get("paragraph");
+ //split
+ List<String> createTableList= SqlSplitVisitor.splitSql(text,paragraphId);
+ int size=0;
+ text="";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ size++;
+ }
+ String title = (String) fromMessage.get("title");
+ Map<String, Object> params = (Map<String, Object>)
fromMessage.get("params");
+ Map<String, Object> config = (Map<String, Object>)
fromMessage.get("config");
+ int finalSize = size;
+ String finalText = text;
+ getNotebook().processNote(noteId,
+ note -> {
+ getNotebookService().runParagraph(note, paragraphId, title, finalText,
params, config, null,
+ false, false, context,
+ new WebSocketServiceCallback<Paragraph>(conn) {
+ @Override
+ public void onSuccess(Paragraph p, ServiceContext context)
+ throws IOException {
+ super.onSuccess(p, context);
+ //change result
+ setResult(p, finalSize,createTableList);
+ if (p.getNote().isPersonalizedMode()) {
+ Paragraph p2 =
p.getNote().clearPersonalizedParagraphOutput(paragraphId,
+ context.getAutheInfo().getUser());
+ connectionManager.unicastParagraph(p.getNote(), p2,
context.getAutheInfo().getUser(), fromMessage.msgId);
+ }
+
+ // if it's the last paragraph and not empty, let's add a new one
Review Comment:
You have copied a lot of code from other places. This should be prevented.
##########
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##########
@@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext
context) throws IOException {
});
}
+ private void setResult(Paragraph p,int size,List<String> createTableList){
+ List<InterpreterResultMessage> resultMessageList= p.getReturn().message();
+ if (p.getReturn().code()== InterpreterResult.Code.SUCCESS){//success
+ if (resultMessageList.size()==size){
+ int successSize=0;
+ for (InterpreterResultMessage
interpreterResultMessage:resultMessageList){
+ if(interpreterResultMessage.equals("Query executed successfully.
Affected rows : 1\n\n")){
+ successSize++;
+ }
+ }
+ if (successSize==size){
+ String text="createTableSql\n";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ }
+ InterpreterResult interpreterResult=new
InterpreterResult(InterpreterResult.Code.SUCCESS,
InterpreterResult.Type.TABLE,text);
+ p.setResult(interpreterResult);
+ }
+ }
+ }
+ }
+
+ private void debugParagraph(NotebookSocket conn,
+ ServiceContext context,
+ Message fromMessage) throws IOException {
+ String paragraphId = (String) fromMessage.get("id");
+ String noteId = connectionManager.getAssociatedNoteId(conn);
+ String text = (String) fromMessage.get("paragraph");
+ //split
+ List<String> createTableList= SqlSplitVisitor.splitSql(text,paragraphId);
+ int size=0;
+ text="";
+ for (String createTableSql:createTableList){
+ text+=createTableSql+"\n";
+ size++;
Review Comment:
Why do you iterate through a list to determine the length of the list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
