Reamer commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582000098
A few thoughts about your work:
- All functionality is located in the JDBC interpreter. All new
dependencies and classes should also be located there.
- It seems that in case of a complex query you modify the dataset with the
JDBC interpreter at the source. With your current implementation, the user is
not aware of this right away.
- You want to cache complex queries with an LRUCache. Depending on the size
of the cache, queries may not be removed from the cache and the user may see
stale data. I think a time based cache would be more appropriate here.
- Have you ever heard of PreparedStatements?
- At first view your configuration options are only JDBC interpreter
configuration, therefore the configuration should be stored only in the JDBC
interpreter and not as global ZeppelinConfiguration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
