Just saw all of the JQuery inside the paragraph, didn't knew it was used so
much.
It's especially used as JQuery.extend to create a copy of scope objects...
While copy can be done using a library like underscore or lodash, or even
angular which has its own copy function (
https://docs.angularjs.org/api/ng/function/angular.copy)

I'm not sure about the part with notebook managing the paragraph,
As a controller, notebook controller should handles the notebook actions,
and as a controller, paragraph controller should handle paragraph actions

On Mon, Jan 12, 2015 at 4:14 PM, Kevin (Sangwoo) Kim <kevin...@apache.org>
wrote:

> I talked with Anthony with this topic before,
> +1 for refactoring server codes.
>
> Also I insist we need some refactoring on front-end codes.
> The biggest problem is Angular and jQuery are mixed and it's really a mess.
> Also I think we need to refine object hierarchy, e,g. a notebook need to
> manage the paragraph inside it.
> (currently many features are rely on global events, sometime it's very
> confusing)
>
> Regards,
> Kevin
>
> On Mon Jan 12 2015 at 4:07:30 PM Anthony Corbacho <
> anthonycorba...@apache.org> wrote:
>
> > Hi,
> >
> > This is a question I wanted to ask for long time.
> > What do you think guys about refactoring Zeppelin (java code a first) to
> > follow the principle of Dependency Injection?
> >
> > The benefit I can list are
> >
> >    - Reduced Dependencies
> >    - Reduced Dependency Carrying
> >    - More Reusable Code
> >    - More Testable Code
> >    - More Readable Code
> >
> > What do you think guys? worth it or not?
> >
> > Best,
> > Anthony
> >
>

Reply via email to