I don't think any PR should wait for PR-56. Instead PR-56 should keep rebase to master. PR-56 can not be blocker for all bug fixes and improvements on zeppelin-web until it's being merged.
Best, moon On Tue, Jun 23, 2015 at 5:12 PM Corneau Damien <cornead...@gmail.com> wrote: > Then, that fix will have to wait for PR 56 to be merged first, otherwise It > will have to be done once more to accomodate new folder structure > On Jun 24, 2015 6:45 AM, "moon soo Lee" <m...@apache.org> wrote: > > > Hi Damien, > > > > Please trying to create separate PR if possible. > > PR-56 is already too big and I think offline font loading is out of scope > > of PR-56. > > It's going to really hard to review and test if you keep add things into > > the single PR. > > Please consider this. > > > > Thanks, > > moon > > > > On Tue, Jun 23, 2015 at 3:50 AM Jongyoul Lee <jongy...@gmail.com> wrote: > > > > > There is no issue created by me yet. I think your PR is a good point to > > > deal with. > > > > > > Thanks > > > JL > > > > > > On Tue, Jun 23, 2015 at 5:38 PM, Corneau Damien <cornead...@apache.org > > > > > wrote: > > > > > > > Basically, you need to remove the @import at the top of home.css > > > > Include Patua, Roboto and Source Code Pro fonts in the project. > > > > And make sure that they are included inside of the project on dev and > > > > build. > > > > > > > > I think I will take care of it in this PR: > > > > https://github.com/apache/incubator-zeppelin/pull/56 > > > > > > > > Is there already a JIRA Issue created that I can refer to in my > commit? > > > > > > > > On Tue, Jun 23, 2015 at 5:14 PM, Jongyoul Lee <jongy...@gmail.com> > > > wrote: > > > > > > > > > Thanks, Corneau, > > > > > > > > > > Could you please guide me to includes these fonts inside my > package? > > > I'm > > > > > note familiar with web. > > > > > > > > > > Thanks in advance, > > > > > JL > > > > > > > > > > On Tue, Jun 23, 2015 at 12:00 PM, Corneau Damien < > > > cornead...@apache.org> > > > > > wrote: > > > > > > > > > > > We could probably include those font inside the project instead > of > > > > using > > > > > > the google Font link. > > > > > > > > > > > > On Tue, Jun 23, 2015 at 11:33 AM, Jongyoul Lee < > jongy...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > > Hi Moon, > > > > > > > > > > > > > > I've found > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-zeppelin/search?utf8=%E2%9C%93&q=fonts.googleapis.com > > > > > > > . I don't know the fetching mechanism exactly, but It looks > like > > > that > > > > > > > initialising zeppelin becomes slow. If it's incorrect, please > > tell > > > > me. > > > > > > > > > > > > > > Thanks, > > > > > > > JL > > > > > > > > > > > > > > On Tue, Jun 23, 2015 at 5:30 AM, moon soo Lee <m...@apache.org > > > > > > wrote: > > > > > > > > > > > > > > > Hi Jongyoul, > > > > > > > > > > > > > > > > Could you specify the resources Zeppelin try to load from > > > internet? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > moon > > > > > > > > > > > > > > > > On Mon, Jun 22, 2015 at 12:30 AM IT CTO <goi....@gmail.com> > > > wrote: > > > > > > > > > > > > > > > > > I guess you refer to the build process? > > > > > > > > > I use the package option which creates a ZIP in the > > > distribution > > > > > > > > directory > > > > > > > > > - after moving the zip to the internal network I just need > to > > > > open > > > > > it > > > > > > > and > > > > > > > > > run the tool. > > > > > > > > > HTH > > > > > > > > > Eran > > > > > > > > > > > > > > > > > > On Mon, Jun 22, 2015 at 9:23 AM, Jongyoul Lee < > > > > jongy...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi dev, > > > > > > > > > > > > > > > > > > > > I have a problem using Zeppelin with private network > > > > environment. > > > > > > My > > > > > > > > > > machine cannot access to internet but Zeppelin looks like > > to > > > > > update > > > > > > > its > > > > > > > > > > resources from internet. How can I disable to update > > > resources > > > > > from > > > > > > > > > > internet? It makes my running too slow. > > > > > > > > > > > > > > > > > > > > Thanks in advance, > > > > > > > > > > Jongyoul Lee > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > 이종열, Jongyoul Lee, 李宗烈 > > > > > > > > > > http://madeng.net > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Eran | CTO > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > 이종열, Jongyoul Lee, 李宗烈 > > > > > > > http://madeng.net > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > 이종열, Jongyoul Lee, 李宗烈 > > > > > http://madeng.net > > > > > > > > > > > > > > > > > > > > > -- > > > 이종열, Jongyoul Lee, 李宗烈 > > > http://madeng.net > > > > > >
