[GitHub] incubator-zeppelin pull request: ZEPPELIN-155 Handle port number 0

[ashwinshankar77]

Github user ashwinshankar77 commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/144#issuecomment-118951118
  
    Hi @Leemoonsoo ,
    Patch works perfect ! thanks. Minor comment : 
    1. the logs prints out 0, when we set websocket to 0 instead of actual port
    15/07/06 18:19:45 INFO socket.NotebookServer: Create zeppelin websocket on 
0.0.0.0:0
    2. When we start zeppelin using zeppelin-daemon.sh, would it make sense to 
print out "http://host:port";
    that the browser should connect to ?
    
    Thanks,
    Ashwin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---