We need to be carefull when merging PR that has zeppelin-web changes for some time. In PR#187 we removed the force option that allow build success when there is jshint errors. So PR based before that point needs to rebase (otherwise CI will be green for them, but not after merge) On Aug 11, 2015 11:19, "madhuka udantha" <madhukaudan...@gmail.com> wrote:
Yes, above error will be fix from PR #202 <https://github.com/apache/incubator-zeppelin/pull/202> On Tue, Aug 11, 2015 at 2:44 PM, IT CTO <goi....@gmail.com> wrote: > Thanks, I will try the patch now. > Eran > > On Tue, Aug 11, 2015 at 12:06 PM Christian Tzolov <ctzo...@pivotal.io> > wrote: > > > I believe that @leemoonsee is working on resolving this: > > https://github.com/apache/incubator-zeppelin/pull/202 > > If you need the patch before it is merged you can merge directly it from > > moon's branch: > > > > git remote add leemoonsoo > > https://github.com/Leemoonsoo/incubator-zeppelin.git > > git fetch leemoonsoo > > git merge leemoonsoo/fix_jshint > > > > On 11 August 2015 at 10:55, IT CTO <goi....@gmail.com> wrote: > > > > > Hi, > > > Just got the latest from master and can't build zeppelin web > > > grunt is failing > > > > > > > > > > > > *Running 'grunt --no-color' in > > > /home/cto/Downloads/incubator-zeppelin-master/zeppelin-web* > > > [INFO] Running "newer:jshint" (newer) task > > > [INFO] > > > [INFO] Running "newer:jshint:all" (newer) task > > > [INFO] No newer files to process. > > > [INFO] > > > [INFO] Running "newer:jshint:test" (newer) task > > > [INFO] > > > [INFO] Running "jshint:test" (jshint) task > > > [INFO] > > > [INFO] test/spec/controllers/notebook.js > > > [INFO] line 11 col 72 'baseUrlSrv' is defined but never used. > > > [INFO] line 11 col 55 'websocketMsgSrv' is defined but never used. > > > [INFO] > > > [INFO] ✖ 2 problems > > > [INFO] > > > [INFO] Warning: Task "jshint:test" failed. Use --force to continue. > > > [INFO] > > > [INFO] Aborted due to warnings. > > > [INFO] > > > [INFO] > > > [INFO] Execution Time (2015-08-11 08:52:21 UTC) > > > [INFO] loading tasks 24ms ▇▇▇▇▇ 11% > > > [INFO] newer:jshint 8ms ▇▇ 4% > > > [INFO] newer:jshint:all 31ms ▇▇▇▇▇▇▇ 15% > > > [INFO] newer:jshint:test 5ms ▇▇ 2% > > > [INFO] jshint:test 139ms ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 66% > > > [INFO] Total 210ms > > > > > > > > > > > -- > > Christian Tzolov <http://www.linkedin.com/in/tzolov> | Solution > Architect, > > EMEA Practice Team | Pivotal <http://pivotal.io/> > > ctzo...@pivotal.io|+31610285517 > > > -- Cheers, Madhuka Udantha http://madhukaudantha.blogspot.com
