Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153138378
Hi,
Sorry for the late response, if I implement the list based on NoteInfo it
means that we only publish Note id and Note Name as implemented in the
Websocket
API here
<https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L280>
,
right?
What about the note info?
Eran
On Fri, Oct 30, 2015 at 9:03 AM Lee moon soo <[email protected]>
wrote:
> I think it would be better if API implementation uses NoteInfo
>
<https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteInfo.java>
> class to generate list, and manage to share the same logic building list
> with Websocket API here
>
<https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L280>
>
> â
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-152445699>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
