Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/465#issuecomment-159453621
@astroshim Sure! Zeppelin project agreed to adhere this styleguide for Java
language https://google.github.io/styleguide/javaguide.html
We encourage all contributors to read this document carefully.
It means that all the code in the project should be formatted according
rules of that guide.
Some of them are enforced through the build system (using checkstyle maven
plugin), like max length of the line - that is why you had
"whitespace\lineLength build error".
Some rules are not enforced automatically, but are a good practices to
follow. This is one of the reasons to have a "code review" in PullRequests here.
Your code looks great, but there are still a few cases where formatting
that can be improved before merging, i.e [horizontal
whitespaing](https://google.github.io/styleguide/javaguide.html#s4.6.2-horizontal-whitespace)
Things like
```java
while(paragraph.getStatus() == Status.PENDING) ...
```
according to the link above should look like
```java
while (paragraph.getStatus() == Status.PENDING) ...
```
Another thing to check is [vertical
whitespace](https://google.github.io/styleguide/javaguide.html#s4.6.1-vertical-whitespace)
- an empty line between two consecutive method fields of the class (fields,
methods).
Please let me know if it that helps!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
