Good points! There's another benefit to it: with a common set of coding styles it'd easier to onboard new contributors. And it is easier for reviewers by sticking to the same ground rules.
Cos On Fri, Nov 27, 2015 at 10:48AM, Felix Cheung wrote: > +1, +1 also on discussing Coding guideline / Coding style on > http://flink.apache.org/contribute-code.html - think we should adopt it as > applicable to this community. > > > From: m...@apache.org > > Date: Fri, 27 Nov 2015 08:23:53 +0000 > > Subject: Re: [DISCUSS]Strict code style and PR guide > > To: dev@zeppelin.incubator.apache.org > > > > So far, we have two related docs. > > > > http://zeppelin.incubator.apache.org/docs/latest/development/howtocontribute.html > > https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md > > > > Having a code-contribution guide, such as Flink's one is going to help not > > only code quality but also getting more code contribution. > > > > I completely agree on this idea and I think community can shape the detail > > of the guide. > > > > I also suggest have one similar to > > http://flink.apache.org/how-to-contribute.html, which is guide to overall > > contribution. > > > > Thanks, > > moon > > > > On Fri, Nov 27, 2015 at 5:00 PM Jongyoul Lee <jongy...@gmail.com> wrote: > > > > > Hi devs, > > > > > > I think It's time to make codes clean and clear. In the former stage of > > > Zeppelin, It's important to add functions to enrich codes but, as time > > > goes, with several codes style, it's hard to maintain code quality. I > > > suggest it's good to follow Flink's way( > > > http://flink.apache.org/contribute-code.html) which looks a little bit > > > strict but that results in a clear code base. > > > > > > Feel free to talk about it, > > > > > > Best, > > > Jongyoul > > > > > > -- > > > ������, Jongyoul Lee, ����֭ > > > http://madeng.net > > > >
signature.asc
Description: Digital signature
