Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-167723271
  
    @khalidhuseynov Thanks for the contribution. I think the approach make 
sense, but the implementation need to be more generalized. We must not assume 
that user will use git notebook repo.
    
    How about add one more interface to 
[NotebookRepo](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java)?
    
    ```
    public void checkpoint(String noteId, String checkPointName);
    ```
    
    and let all notebookrepo implement this interface. This method can be 
invoked with proposed GUI.
    Each different notebook storage implementation can implement checkpoint() 
for their own purpose. GitNotebookRepo use this method for making commit, for 
example.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to