GitHub user r-kamath opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/633

    Update default notebook generateName function for create note dialog

    ### What is this PR for?
    The current default name for a notebook in create dialog is random, which 
is difficult to remember.
    Instead of randomly generating names it's useful to have a prefix "Untitled 
Note " + seq number.
    eg: Untitled Note 1, Untitled Note 2 etc.
    
    ### What type of PR is it?
    Improvement
    
    ### How should this be tested?
    Create note with default names populated in the field and check if the 
naming sequence is correct.
    When there are no notes with "Untitled Note <num>" the default name should 
be "Untitled Note 1", otherwise it should be max num + 1.
    
    ### Screenshots
    Before
    <img width="659" alt="before" 
src="https://cloud.githubusercontent.com/assets/2031306/12294473/c63d823a-ba20-11e5-8e7d-6d9df098ab05.png";>
    <hr>
    <img width="632" alt="after1" 
src="https://cloud.githubusercontent.com/assets/2031306/12294476/cff636dc-ba20-11e5-82a1-dab7ade0fc7c.png";>
    <img width="637" alt="after2" 
src="https://cloud.githubusercontent.com/assets/2031306/12294478/d3c5232c-ba20-11e5-8265-69ce41a1370b.png";>
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/incubator-zeppelin noteNameUpdate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #633
    
----
commit 39fe8b60bd9377b80f2c2885ef7372978c368bbd
Author: Renjith Kamath <renjith.kam...@gmail.com>
Date:   2016-01-13T12:23:28Z

    Update the logic to generate default notebook name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to