[GitHub] incubator-zeppelin pull request: ZEPPELIN-625 ] Notebook Storage m...

[cloverhearts]

GitHub user cloverhearts opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/659

    ZEPPELIN-625 ] Notebook Storage module dynamic loading

    ### What is this PR for?
    Features developed for dynamic loads Notebook Storage Module.
    In addition to the current Local Storage S3, it is possible to manage the 
notebook with Git.
    But, at the same time you can not use another Notebook Storage Module, 
always include the Zeppelin Project shall be developed and downloaded.
    
    To Solved, getting down the Notebook Storage Module from the Maven 
repository, and configure it so that you can dynamically load.
    
    https://issues.apache.org/jira/browse/ZEPPELIN-546
    
    ```
    params:
       artifact - maven artifact (groupId:artifactId:version)
       className - Interpreter class
       repository (optional) - additional maven repository address
    ```
    
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - Implement dynamic load notebook storage module in notebooksync.java
    
    ### Is there a relevant Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-625
    https://issues.apache.org/jira/browse/ZEPPELIN-546
    
    ### How should this be tested?
    1. Create a new Notebook storage module for testing.
    example
    ```
    
myNotebookStorage/org/apache/zeppelin/myNotebookStorage/MyNotebookStorage.java
    
    public class MyNotebookStorage implements NotebookRepo {
        ...implement interface method.
    }
    ```
    
    2. maven local repository build.
    incubator-zeppelin root directory path.
    ```
    mvn install -pl 
'!spark-dependencies,!spark,!flink,!ignite,!lens,!hive,!phoenix,!postgresql,!tajo,!cassandra,!kylin,!elasticsearch,!zeppelin-distribution'
 -DskipTests
    ```
    then execute normal build.
    ```
    mvn clean package -Pspark-1.6 -Phadoop-2.4 -Ppyspark -DskipTests
    ```
    
    3. It calls for the implementation of the method.
    ```
    
loadDynamicNoteBookStorage("org.apache.zeppelin.myNotebookStorage.MyNotebookStorage",
 "org.apache.zeppelin:myNotebookModuleID:0.6.0-incubating-SNAPSHOT")
    ```
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/incubator-zeppelin 
DynamicNotebookStorage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #659
    
----
commit 18c8f85976466b9ab29d6e011405717ee8fc8e46
Author: Estail7s <estai...@gmail.com>
Date:   2016-01-19T05:06:56Z

    Implement Dynamic load Notebook Storage module.

commit 4cd29dd82fc6973258573381f7e6a152bf4c0cd4
Author: Estail7s <estai...@gmail.com>
Date:   2016-01-20T06:05:13Z

    modified method DynamicNotebook . Delete unnecessary code and fixed indent.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---