GitHub user MikeTYChen opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/665
Keyboard Shortcut - Map Alt or Opt Based on Device
### What is this PR for?
Right now the keyboard shortcut modal shows 'alt' but on macs 'alt' maps to
'opt'. Could be confusing to some people who don't see 'alt' on the keyboard on
their macs.
There are many way to achieve this mapping. I used this to minimize code
change and take advantage of when paragraphs check for appVersion to set
keyboard shortcuts.
Open to suggestions on best approach to solve this problem.
### What type of PR is it?
Improvement
### Todos
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-626
### How should this be tested?
1. Emulate browser to be Mac and open keyboard shortcut
2. Emulate browser to be Windows and open keyboard shortcut
### Screenshots (if appropriate)
Macs:
Windows:
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeTYChen/incubator-zeppelin ZEPPELIN-626
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #665
----
commit b578e889cb8520736be10265de4483a65ba60e3e
Author: Michael Chen <miketyc...@gmail.com>
Date: 2016-01-21T17:09:40Z
map alt or opt based on device
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
