Hello guys

 While developing a new feature, I can see some inconsistencies in the
design of the AngularObjecRegistry and RemoteAngularObjectRegistry classes.

 The remote class extends the base AngularObjecRegistry class, so it also
inherits the values HashMap.

 The problem is that this value HashMap is JVM-local, therefore, there are
some methods like addAndNotifyRemoteProcess()
and removeAndNotifyRemoteProcess() to add/remove variables to/from the
remote registry.

 So far so good.

 But then there is no method to read/check the presence of a variable from
the remote registry. Calling get() only read the local HashMap ....

 Ideally, the addAndNotifyRemoteProcess() should be renamed add() and
override the add() method of the base AngularObjecRegistry class. Same idea
for removeAndNotifyRemoteProcess() method. If we are dealing with a remote
registry, that make senses that we do not use the JVM-local HashMap.

 What do you think about the idea ? Is there any use-case where we DO need
to access the local HashMap for a RemoteAngularObjectRegistry instance ?

Remarks are welcomed

Regards

Reply via email to