GitHub user schnee reopened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/662

    moved delete button to help protect against accidental clicks

    ### What is this PR for?
    The delete notebook action is embedded in the button bar with several other 
buttons, increasing the potential for an accidental click. This PR moves the 
delete button out of the "normal" button bar.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    (none)
    
    ### Is there a relevant Jira issue?
    No
    
    ### How should this be tested?
    Create new notebook
    populate notebook
    delete notebook
    
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schnee/incubator-zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #662
    
----
commit d3deac058028f62e9111065781ca98bed2c50b07
Author: Brent Schneeman <schnee...@gmail.com>
Date:   2016-01-20T17:32:30Z

    moved delete button to help protect against accidental clicks

commit 3d45544d95f40c5e9c2b2c365e66be3dd407ec6c
Author: Brent Schneeman <schnee...@gmail.com>
Date:   2016-01-21T14:03:54Z

    span styling applied

commit 9b75fdf2a73c7270b162fd19ca25f7d87c6bf4ac
Author: Brent Schneeman <schnee...@gmail.com>
Date:   2016-01-22T17:29:35Z

    more accurate styling

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to