Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/655#issuecomment-177298867
@doanduyhai Thanks for review and i think i addressed all your comment.
Please take a look.
Regarding ResourcePool and AngularObjectRegistry, here's differences
- ResourcePool is not propagating object from/to front-end, but
AngularObjectRegistry do.
- ResourcePool is not persisted into note.json but AngularObjectRegistry
does.
- AngularObjectRegistry has scope (paragraph/notebook) but ResourcePool
does not.
I agree, if we improve ResourcePool more and replace AngularObjectRegistry,
that would be simpler and better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
