Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/654#issuecomment-179386505
  
    Very nice useage of `Enum` here!
    
    Probably a knit-piking but may be also `SHIFT_ENTER` diserves a place there 
too?
    
    Looks great to me.
    
    I'm just curious, may be you know, why open parentesys is a key, but 
closing one seems to be ok inside the string literal?
    
    :+1: for more tests that help improving stability!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to